Re: [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest

[Michael S. Tsirkin]

On Wed, Sep 25, 2013 at 02:48:52PM +0200, Gerd Hoffmann wrote:
> On Mi, 2013-09-25 at 14:22 +0300, Michael S. Tsirkin wrote:
> > This code can also be found here:
> > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi
> > 
> > While this patch still uses info not available in QOM, I think it's 
> > reasonable
> > to merge it and then refactor as QOM properties cover more ground.
> 
> Testing with coreboot (-M pc only so far, -M q35 tbd).
> 
> address@hidden ~]# cat /proc/ioports 
>   [ ... ]
>   afe0-afe3 : ACPI GPE0_BLK
>   b010-b015 : ACPI CPU throttle
>   b100-b10f : 0000:00:01.3
>     b100-b107 : piix4_smbus
>   e400-e43f : 0000:00:01.3
>     e400-e403 : ACPI PM1a_EVT_BLK
>     e404-e405 : ACPI PM1a_CNT_BLK
>     e408-e40b : ACPI PM_TMR
> 
> "ACPI CPU throttle" looks wrong, probably hardcoded to 0xb010 instead of
> pmbase+0x10.

Hmm hardcoded where? Do you know where this comes from?

> Otherwise it looks good so far.
> 
> cheers,
>   Gerd
> 
>