qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] Extend qemu-ga's 'guest-info' command to exp


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'
Date: Thu, 26 Sep 2013 05:42:48 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 09/25/2013 07:57 PM, Mark Wu wrote:
> Now we have several qemu-ga commands not returning response on success.
> It has been documented in qga/qapi-schema.json already. This patch exposes
> the 'success-response' flag by extending 'guest-info' command. With this
> change, the clients can handle the command response more flexibly.
> 
> Signed-off-by: Mark Wu <address@hidden>
> ---
> Changes:
> v3: 
>        1. treat cmd->options as a bitmask instead of single option (per Eric) 
>        2. rebase on the patch " Add interface to traverse the qmp command list
>     by QmpCommand" to avoid the O(n2) problem (per Eric and Michael)
> v2: 
>     add the notation 'since 1.7' to the option 'success-response'
>     (per Eric Blake's comments)
> 
>  qga/commands.c       | 1 +
>  qga/qapi-schema.json | 5 ++++-
>  2 files changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]