[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: fix translation of sse {, u}comis{
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: fix translation of sse {, u}comis{s, d} instructions |
|
Date: |
Thu, 26 Sep 2013 07:15:49 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/25/2013 01:20 PM, Nathan Froyd wrote:
> While the generic SSE translation codepath contains special logic to use
> 32-bit or 64-bit memory operands for some instructions, this logic doesn't
> catch the SSE {,u}comis{s,d} instructions. This oversight leads to too
> many bytes being read when those instructions use memory operands, which
> can in turn lead to page faults.
>
> The fix is simple: add a special case for these instructions. It did not
> fit cleanly into the existing case, so some cut-and-paste was necesary.
>
> Signed-off-by: Nathan Froyd <address@hidden>
> ---
> target-i386/translate.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Richard Henderson <address@hidden>
r~