[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2: count_contiguous_clusters and compressio
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] qcow2: count_contiguous_clusters and compression |
|
Date: |
Fri, 27 Sep 2013 11:31:10 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 25.09.2013 um 17:47 hat Max Reitz geschrieben:
> The function is not intended to be used on compressed clusters and will
> not work correctly, if used anyway, since L2E_OFFSET_MASK is not the
> right mask for determining the offset of compressed clusters. Therefore,
> assert that the first cluster is not compressed and always include the
> compression flag in the mask of significant flags, i.e., stop the search
> as soon as a compressed cluster occurs.
>
> Signed-off-by: Max Reitz <address@hidden>
This is supposed to be a cleanup patch with no functional change, right?
How about removing explicit QCOW_OFLAG_COMPRESSED arguments from
callers?
Kevin