Re: [Qemu-devel] [PATCH 2/3] qcow2: Free allocated L2 cluster on error

[Kevin Wolf]

Am 25.09.2013 um 16:37 hat Max Reitz geschrieben:
> If an error occurs in l2_allocate, the allocated (but unused) L2 cluster
> should be freed.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block/qcow2-cluster.c | 4 ++++
>  1 file changed, 4 insertions(+)

This needs an update of the reference output for test case 026 (both for
-nocache and writethrough).

Most of the changes look expected and good, like cluster leaks
disappearing. With -nocache, however, there are a few cases that failed
previously and result in successful writes now. It would be interesting
to see the explanation for these before we merge the patch.

Kevin