qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 30/60] AArch64: Add extr instruction emulation


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 30/60] AArch64: Add extr instruction emulation
Date: Fri, 27 Sep 2013 12:45:20 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 09/26/2013 05:48 PM, Alexander Graf wrote:
> +    if (is_32bit) {
> +        tcg_gen_ext32u_i64(tcg_tmp, cpu_reg(rm));
> +    } else {
> +        tcg_gen_mov_i64(tcg_tmp, cpu_reg(rm));
> +    }
> +    tcg_gen_shri_i64(tcg_res, cpu_reg(rm), imms);
> +    tcg_gen_shli_i64(tcg_tmp, cpu_reg(rn), bitsize - imms);
> +    tcg_gen_or_i64(cpu_reg(rd), tcg_tmp, tcg_res);

The first ext/mov is incorrectly unused.  This will
produce incorrect results for is_32bit.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]