qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] exec: Fix prototype of phys_mem_set_alloc and r


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] exec: Fix prototype of phys_mem_set_alloc and related functions
Date: Mon, 30 Sep 2013 10:38:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Stefan Weil <address@hidden> writes:

> phys_mem_alloc and its assigned values qemu_anon_ram_alloc and
> legacy_s390_alloc must have identical argument lists.
>
> legacy_s390_alloc uses the size parameter to call mmap, so size_t is
> good enough for all of them.
>
> This patch fixes compiler errors on i686 Linux hosts:
>
>   CC    alpha-softmmu/exec.o
> exec.c:752:51: error:
>  initialization from incompatible pointer type [-Werror]
> exec.c: In function 'qemu_ram_alloc_from_ptr':
> exec.c:1139:32: error:
>  comparison of distinct pointer types lacks a cast [-Werror]
> exec.c: In function 'qemu_ram_remap':
> exec.c:1283:21: error:
>  comparison of distinct pointer types lacks a cast [-Werror]
>
> Signed-off-by: Stefan Weil <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]