[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin |
Date: |
Mon, 30 Sep 2013 12:14:57 +0300 |
On Mon, Sep 30, 2013 at 11:02:06AM +0200, Paolo Bonzini wrote:
> Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto:
> >>> > > As a next step, can we make pci_set_irq non-inline and make
> >>> > > it call pci_irq_handler directly, and get rid of the irq field?
> >> > What irq field?
> > /* IRQ objects for the INTA-INTD pins. */
> > qemu_irq *irq;
> >
>
> That's still used by devices that use common code for PCI and sysbus
> versions (e.g. USB OHCI and EHCI).
>
> Paolo
Well this work wouldn't be complete without
addressing them anyway.
These devices would have to create their own
irq in pci-specific code, along the lines of:
- s->irq = dev->irq[3];
+ s->irq = qemu_allocate_irqs(pci_set_irq, dev, 1);
If there's more than one device like this, we should add
/* Return an irq that calls pci_set_irq internally */
qemu_irq *pci_allocate_irq(PCIDevice *);
--
MST
- [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Marcel Apfelbaum, 2013/09/29
- [Qemu-devel] [PATCH 1/3] hw/pci: set irq without selecting INTx pin, Marcel Apfelbaum, 2013/09/29
- [Qemu-devel] [PATCH 2/3] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init, Marcel Apfelbaum, 2013/09/29
- [Qemu-devel] [PATCH 3/3] hw: assert/deassert interrupts using pci_set_irq wrapper, Marcel Apfelbaum, 2013/09/29
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Michael S. Tsirkin, 2013/09/29
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Marcel Apfelbaum, 2013/09/29
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Marcel Apfelbaum, 2013/09/30
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Paolo Bonzini, 2013/09/30
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Marcel Apfelbaum, 2013/09/30
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Marcel Apfelbaum, 2013/09/30
- Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin, Paolo Bonzini, 2013/09/30