Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

[Markus Armbruster]

"Michael S. Tsirkin" <address@hidden> writes:

> On Mon, Sep 30, 2013 at 05:49:26PM +0200, Markus Armbruster wrote:
>> Peter Maydell <address@hidden> writes:
>> 
>> > On 30 September 2013 23:40, Michael S. Tsirkin <address@hidden> wrote:
>> >> diff --git a/include/qapi/error.h b/include/qapi/error.h
>> >> index 7d4c696..b85e996 100644
>> >> --- a/include/qapi/error.h
>> >> +++ b/include/qapi/error.h
>> >> @@ -13,14 +13,15 @@
>> >>  #define ERROR_H
>> >>
>> >>  #include "qemu/compiler.h"
>> >> +#include "qemu/typedefs.h"
>> >>  #include "qapi-types.h"
>> >>  #include <stdbool.h>
>> >>
>> >>  /**
>> >> - * A class representing internal errors within QEMU.  An error has a 
>> >> ErrorClass
>> >> + * Error:
>> >> + * An object representing internal errors within QEMU.  An error has a 
>> >> ErrorClass
>> >>   * code and a human message.
>> >>   */
>> >> -typedef struct Error Error;
>> >
>> > Does the process-doc-comments tool really cope with documentation comments
>> > that are completely separate from the typedef like this?
>> 
>> Even if they do, I don't.
>
> What kind of error do you encounter?

Even if $magic-tool could somehow find the documentation comments even
when they're far from the definitions they apply to, non-magic old me
can't.