[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/10] target-s390: Fix STIDP
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 07/10] target-s390: Fix STIDP |
Date: |
Mon, 30 Sep 2013 12:48:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/30/2013 11:13 AM, Alexander Graf wrote:
>> - int cpu_num;
>> + union {
>> + uint64_t cpuid;
>> + struct {
>> +#ifdef HOST_WORDS_BIGENDIAN
>> + uint32_t cpu_num;
>> + uint32_t machine_type;
>> +#else
>> + uint32_t machine_type;
>> + uint32_t cpu_num;
>> +#endif
>
> Are we guaranteed that we don't need to pack? Also anonymous unions/structs
> are
> a gcc extension IIRC. And why do you swap endianness here, but not above when
> defining the machine_type value?
(1) I can't imagine that we would; such struct/unions are used all over.
(2) Sure, but we've so many other gcc extensions I figured it didn't matter.
(3) Of course. I want host endianness, not target endianness.
r~
- [Qemu-devel] [PATCH 04/10] target-s390: Raise OPERATION exception for disabled insns, (continued)
- [Qemu-devel] [PATCH 04/10] target-s390: Raise OPERATION exception for disabled insns, Richard Henderson, 2013/09/23
- [Qemu-devel] [PATCH 02/10] target-s390: Implement STFLE, Richard Henderson, 2013/09/23
- [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env, Richard Henderson, 2013/09/23
- [Qemu-devel] [PATCH 03/10] target-s390: Add facilities bits and sets, Richard Henderson, 2013/09/23
- [Qemu-devel] [PATCH 06/10] target-s390: Implement EPSW, Richard Henderson, 2013/09/23
- [Qemu-devel] [PATCH 05/10] target-s390: Implement SAM31 and SAM64, Richard Henderson, 2013/09/23
- [Qemu-devel] [PATCH 07/10] target-s390: Fix STIDP, Richard Henderson, 2013/09/23
- [Qemu-devel] [PATCH 10/10] target-s390: Implement ECAG, Richard Henderson, 2013/09/23
- [Qemu-devel] [PATCH 09/10] target-s390: Implement LURA, LURAG, STURG, Richard Henderson, 2013/09/23
- [Qemu-devel] [PATCH 08/10] target-s390: Fix STURA, Richard Henderson, 2013/09/23
- Re: [Qemu-devel] [PATCH 0/9] target-s390 tcg improvements, Alexander Graf, 2013/09/30