[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 5/6] qemu-iotests: Discard specific info in _img_
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v7 5/6] qemu-iotests: Discard specific info in _img_info |
Date: |
Wed, 2 Oct 2013 10:39:39 +0200 |
In _img_info, filter out additional information specific to the image
format provided by qemu-img info, since tests designed for multiple
image formats would produce different outputs for every image format
otherwise.
In a human-readable dump, that new information will always be last for
each "image information block" (multiple blocks are emitted when
inspecting the backing file chain). Every block is separated by an empty
line. Therefore, in this case, everything starting with the line "Format
specific information:" up to that empty line (or EOF, if it is the last
block) has to be stripped.
The JSON dump will always emit pretty JSON data. Therefore, the opening
and closing braces of every object will be on lines which are indented
by exactly the same amount, and all lines in between will have more
indentation. Thus, in this case, everything starting with a line
matching the regular expression /^ *"format-specific": {/ until /^ *},?/
has to be stripped, where the number of spaces at the beginning of the
respective lines is equal.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
tests/qemu-iotests/common.rc | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index 1b22db0..227c003 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -197,12 +197,30 @@ _check_test_img()
_img_info()
{
+ discard=0
+ regex_json_spec_start='^ *"format-specific": \{'
$QEMU_IMG info "$@" "$TEST_IMG" 2>&1 | \
sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \
-e "s#$TEST_DIR#TEST_DIR#g" \
-e "s#$IMGFMT#IMGFMT#g" \
-e "/^disk size:/ D" \
- -e "/actual-size/ D"
+ -e "/actual-size/ D" | \
+ while IFS='' read line; do
+ if [[ $line == "Format specific information:" ]]; then
+ discard=1
+ elif [[ $line =~ $regex_json_spec_start ]]; then
+ discard=2
+ regex_json_spec_end="^${line%%[^ ]*}\\},? *$"
+ fi
+ if [[ $discard == 0 ]]; then
+ echo "$line"
+ elif [[ $discard == 1 && ! $line ]]; then
+ echo
+ discard=0
+ elif [[ $discard == 2 && $line =~ $regex_json_spec_end ]]; then
+ discard=0
+ fi
+ done
}
_get_pids_by_name()
--
1.8.3.1
- [Qemu-devel] [PATCH v7 0/6] Provide additional info through qemu-img info, Max Reitz, 2013/10/02
- [Qemu-devel] [PATCH v7 1/6] qapi: Add ImageInfoSpecific type, Max Reitz, 2013/10/02
- [Qemu-devel] [PATCH v7 2/6] block: Add bdrv_get_specific_info, Max Reitz, 2013/10/02
- [Qemu-devel] [PATCH v7 4/6] qcow2: Add support for ImageInfoSpecific, Max Reitz, 2013/10/02
- [Qemu-devel] [PATCH v7 3/6] block/qapi: Human-readable ImageInfoSpecific dump, Max Reitz, 2013/10/02
- [Qemu-devel] [PATCH v7 6/6] qemu-iotests: Additional info from qemu-img info, Max Reitz, 2013/10/02
- [Qemu-devel] [PATCH v7 5/6] qemu-iotests: Discard specific info in _img_info,
Max Reitz <=