Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

[Igor Mammedov]

On Wed, 21 Aug 2013 13:01:32 +0200
Gerd Hoffmann <address@hidden> wrote:

>   Hi,
> 
> > +#define ICH9_PROC_BASE 0xaf00
> > +#define ICH9_PROC_LEN 32
> 
> No, please don't.  It makes it impossible to assign the 0xa000 -> 0xafff
> I/O port window to a PCI bridge.  Please lets stop occupy random io
> ports above 0x1000 and burn I/O address space that way.
I'm curios why 0x1000 is any better than 0xa000, it still would be random
port occupation. Is there any guideline which ports could be used and which
shouldn't?

Could we safely move PIIX CPU hotplug 0xaf00-0xaf20 range below 0x1000?

> 
> I'd suggest to place it at 0x0a00 instead.  Also the dsdt should get a
> device with the address in _CRS so the guest knows those ports are used.


> 
> cheers,
>   Gerd
> 
> 
> 
>