Re: [Qemu-devel] [Qemu-trivial] [PATCH] util/path: Fix type which is longer than 8 bit for MinGW

[Michael Tokarev]

03.10.2013 00:40, Stefan Weil wrote:
> While dirent->d_type is 8 bit for most systems, it is 32 bit for MinGW.
> Reducing it to 8 bit results in a compiler warning because the macro
> is_dir_maybe compares that 8 bit value with 32 bit constants.
>
> Using 'unsigned' instead of 'unsigned char' matches the declaration for
> MinGW and does not harm the other systems.
>
> MinGW-w32 is not affected: it does not declare d_type.

That's a good one.

What's the diff between mingw-w32 and mingw?

At any rate, there's - I think - no need to declare it as 'char',
int or unsigned should be just fine.

Thanks, applied to the trivial patches queue.

/mjt