qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V9 11/11] quorum: Add quorum_open() and quorum_c


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH V9 11/11] quorum: Add quorum_open() and quorum_close().
Date: Mon, 07 Oct 2013 09:23:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9

On 2013-10-04 17:31, Eric Blake wrote:
On 10/04/2013 09:14 AM, Max Reitz wrote:
On 2013-10-02 14:39, Benoît Canet wrote:
Example of command line:
-drive if=virtio,file.driver=quorum,\
file.children.0.file.filename=1.qcow2,\
file.children.1.file.filename=2.qcow2,\
file.children.2.file.filename=3.qcow2,\
file.vote_threshold=3

Third, wouldn't it be better to use children[i] instead of children.i
for addressing them on the command line? I guess, a QMP interface would
represent them as an array, so using the standard array index notation
seems better to me.
No, we already discussed this.  file.child[0].file.filename=1.qcow2
requires shell quoting to avoid unintentional shell globbing;
file.child.0.file.filename=1.qcow2 is just as legible and can still be
reconstructed into an array under the hood, and has the benefit of not
needing quoting to protect against shell globbing.

Oh, sorry.I thought escaping wouldn't hurt too much; but well, on second thought, for an interface that's purely designed for the command line it's probably best to avoid the need for it as much as possible.

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]