Re: [Qemu-devel] savevm/loadvm

[Kevin Wolf]

Am 08.10.2013 um 11:04 hat Paolo Bonzini geschrieben:
> Il 08/10/2013 10:40, Alexey Kardashevskiy ha scritto:
> > However qcow2_save_vmstate() sets bs->growable to 1 for a short time
> > (commit 178e08a58f40dd5aef2ce774fe0850f5d0e56918 from 2009) and this
> > triggers a branch in bdrv_co_do_writev() which changes bs->total_sectors.
> > So when QEMU writes snapshots to the file, the disk_size field of a
> > snapshot has bigger value (for example 0x4.007b.8180).
> 
> I think you need to modify qcow2_save_vmstate to save and restore
> bs->total_sectors.  Can you test that and if so post the patch?

It's a regression introduced by commit df2a6f29, right?

What you suggest probably works as a quick hack to fix the bug. The VM
state functions in qcow2 are getting uglier and uglier, though. Maybe
they should avoid going through block.c and adding hacks to disable or
revert side effects.

Kevin