[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 10/17] blockdev: Move parsing of 'boot' option to
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v3 10/17] blockdev: Move parsing of 'boot' option to drive_init |
Date: |
Tue, 8 Oct 2013 14:16:27 +0200 |
It's already ignored and only prints a deprecation message. No use in
making it available in new interfaces.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
blockdev.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index b1c7590..85e412a 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -456,12 +456,6 @@ static DriveInfo *blockdev_init(QDict *bs_opts,
return NULL;
}
- if (qemu_opt_get(opts, "boot") != NULL) {
- fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
- "ignored. Future versions will reject this parameter. Please "
- "update your scripts.\n");
- }
-
on_write_error = BLOCKDEV_ON_ERROR_ENOSPC;
if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type !=
IF_NONE) {
@@ -713,6 +707,10 @@ QemuOptsList qemu_legacy_drive_opts = {
.name = "trans",
.type = QEMU_OPT_STRING,
.help = "chs translation (auto, lba, none)",
+ },{
+ .name = "boot",
+ .type = QEMU_OPT_BOOL,
+ .help = "(deprecated, ignored)",
},
{ /* end of list */ }
},
@@ -788,6 +786,13 @@ DriveInfo *drive_init(QemuOpts *all_opts,
BlockInterfaceType block_default_type)
goto fail;
}
+ /* Deprecated option boot=[on|off] */
+ if (qemu_opt_get(legacy_opts, "boot") != NULL) {
+ fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
+ "ignored. Future versions will reject this parameter. Please "
+ "update your scripts.\n");
+ }
+
/* Media type */
value = qemu_opt_get(legacy_opts, "media");
if (value) {
@@ -2328,10 +2333,6 @@ QemuOptsList qemu_common_drive_opts = {
.name = "copy-on-read",
.type = QEMU_OPT_BOOL,
.help = "copy read data from backing file into image file",
- },{
- .name = "boot",
- .type = QEMU_OPT_BOOL,
- .help = "(deprecated, ignored)",
},
{ /* end of list */ }
},
--
1.8.1.4
- [Qemu-devel] [PATCH v3 00/17] blockdev-add QMP command, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 01/17] qapi-types/visit.py: Pass whole expr dict for structs, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 02/17] qapi-types/visit.py: Inheritance for structs, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 03/17] blockdev: Introduce DriveInfo.enable_auto_del, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 06/17] blockdev: Pass QDict to blockdev_init(), Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 04/17] blockdev: 'blockdev-add' QMP command, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 05/17] blockdev: Separate ID generation from DriveInfo creation, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 07/17] blockdev: Move parsing of 'media' option to drive_init, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 08/17] blockdev: Move parsing of 'if' option to drive_init, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 09/17] blockdev: Moving parsing of geometry options to drive_init, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 10/17] blockdev: Move parsing of 'boot' option to drive_init,
Kevin Wolf <=
- [Qemu-devel] [PATCH v3 11/17] blockdev: Move bus/unit/index processing to drive_init, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 12/17] blockdev: Move virtio-blk device creation to drive_init, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 13/17] blockdev: Remove IF_* check for read-only blockdev_init, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 14/17] qemu-iotests: Check autodel behaviour for device_del, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 15/17] blockdev: Remove 'media' parameter from blockdev_init(), Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 16/17] blockdev: Don't disable COR automatically with blockdev-add, Kevin Wolf, 2013/10/08
- [Qemu-devel] [PATCH v3 17/17] blockdev: blockdev_init() error conversion, Kevin Wolf, 2013/10/08