Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

[Kevin Wolf]

Am 02.10.2013 um 17:46 hat Paolo Bonzini geschrieben:
> Il 02/10/2013 17:41, Peter Lieven ha scritto:
> > this converts read, write and flush functions from aio to coroutines.
> 
> I'm not sure it's already the time for this...  Cancellation sucks in
> QEMU, and this is going to make things even worse.

Not sure what you're referring to. If you mean iscsi_aio_cancel(), isn't
it dead code anyway since we changed block.c to use coroutines for
everything? bdrv_co_io_em() even throws the acb away, so even if you
wanted, there's no way to cancel the request even today.

And the lines deleted/inserted are much in favour of this patch.

Kevin