[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices |
Date: |
Tue, 08 Oct 2013 14:36:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 08/10/2013 14:05, Peter Lieven ha scritto:
>> Strictly speaking, this should probably do something like this:
>>
>> assert(ret & BDRV_BLOCK_OFFSET_VALID);
>> return bdrv_get_block_status(bs->file, ret >> BDRV_SECTOR_BITS,
>> nb_sectors, pnum);
> shouldn't the last line be:
>
> return bdrv_get_block_status(bs->file, ret >> BDRV_SECTOR_BITS,
> *pnum, pnum);
>
>
> This would of course require *pnum = nb_sectors in raw_co_get_block_status
> ?
Yes for both questions.
Paolo