[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] qapi: make use of new BlockJobType
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] qapi: make use of new BlockJobType |
|
Date: |
Tue, 08 Oct 2013 07:06:15 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
On 10/08/2013 03:29 AM, Fam Zheng wrote:
> Switch the string to enum type BlockJobType in BlockJobDriver.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> +++ b/include/block/blockjob.h
> @@ -37,7 +37,7 @@ typedef struct BlockJobDriver {
> size_t instance_size;
>
> /** String describing the operation, part of query-block-jobs QMP API */
> - const char *job_type;
> + BlockJobType job_type;
Comment looks awkward now that it is not a string in memory; but it is
still a string on the wire, so I can live with it as-is.
Series: Reviewed-by: Eric Blake <address@hidden>
Thanks for doing this!
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature