Re: [Qemu-devel] [PATCH 4/8] timers: reorganize icount_warp_rt

[Alex Bligh]

On 8 Oct 2013, at 09:47, Paolo Bonzini wrote:

> To prepare for future code changes, move the increment of qemu_icount_bias
> outside the "if" statement.
> 
> Also, hoist outside the if the check for timers that expired due to the
> "warping".  The check is redundant when !runstate_is_running(), but
> doing it this way helps because the code that increments qemu_icount_bias
> will be a critical section.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> cpus.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)

Looks good - too much icount mindbending for Reviewed-By:

-- 
Alex Bligh