[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 26/28] memory: use find_next_bit() to find dirty bit
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 26/28] memory: use find_next_bit() to find dirty bits |
Date: |
Wed, 9 Oct 2013 13:28:48 +0200 |
This operation is way faster that doing it bit by bit.
Signed-off-by: Juan Quintela <address@hidden>
---
include/exec/memory-internal.h | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index 0c1dbfa..5a5bc0d 100644
--- a/include/exec/memory-internal.h
+++ b/include/exec/memory-internal.h
@@ -44,18 +44,15 @@ static inline bool cpu_physical_memory_get_dirty(ram_addr_t
start,
ram_addr_t length,
unsigned client)
{
- ram_addr_t addr, end;
+ unsigned long end, page, next;
assert(client < DIRTY_MEMORY_NUM);
- end = TARGET_PAGE_ALIGN(start + length);
- start &= TARGET_PAGE_MASK;
- for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
- if (test_bit(addr >> TARGET_PAGE_BITS, ram_list.dirty_memory[client]))
{
- return true;
- }
- }
- return false;
+ end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS;
+ page = start >> TARGET_PAGE_BITS;
+ next = find_next_bit(ram_list.dirty_memory[client], end, page);
+
+ return next < end;
}
static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr,
--
1.8.3.1
- [Qemu-devel] [PATCH 17/28] memory: cpu_physical_memory_clear_dirty_flag() result is never used, (continued)
- [Qemu-devel] [PATCH 17/28] memory: cpu_physical_memory_clear_dirty_flag() result is never used, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 18/28] bitmap: Add bitmap_zero_extend operation, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 19/28] memory: split dirty bitmap into three, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 20/28] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 21/28] memory: unfold cpu_physical_memory_set_dirty() in its only user, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 23/28] memory: make cpu_physical_memory_get_dirty() the main function, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 22/28] memory: unfold cpu_physical_memory_set_dirty_flag(), Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 25/28] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 24/28] memory: cpu_physical_memory_get_dirty() is used as returning a bool, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 26/28] memory: use find_next_bit() to find dirty bits,
Juan Quintela <=
- [Qemu-devel] [PATCH 27/28] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 28/28] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations, Juan Quintela, 2013/10/09
- Re: [Qemu-devel] [RFC 00/28] bitmap handling optimization, Paolo Bonzini, 2013/10/09