qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when ma


From: Alex Bligh
Subject: Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events
Date: Wed, 9 Oct 2013 19:28:39 +0100

On 9 Oct 2013, at 19:03, Hans de Goede wrote:

> static void audio_reset_timer (AudioState *s)
> {
>    if (audio_is_timer_needed ()) {
>        timer_mod (s->ts, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 1);
>    }
>    else {
>        timer_del (s->ts);
>    }
> }
> 
> static void audio_timer (void *opaque)
> {
>    audio_run ("timer");
>    audio_reset_timer (opaque);
> }
> 
> Note how that is using a timer which expires every freaking nano second,
> I think it is very likely that is the culprit.

Indeed. I am hoping that it is not my automated perl conversion code that
did that, because if it is, it may have broken other stuff :-/

Thanks for finding this - let me see whether the bug existed before
my automated changes commit.

-- 
Alex Bligh







reply via email to

[Prev in Thread] Current Thread [Next in Thread]