[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/28] exec: simplify notdirty_mem_write()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 08/28] exec: simplify notdirty_mem_write() |
Date: |
Wed, 09 Oct 2013 13:10:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
On 10/09/2013 05:28 AM, Juan Quintela wrote:
> We don't need to make special things for CODE, just set the other two bits
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> exec.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> - dirty_flags |= (0xff & ~CODE_DIRTY_FLAG);
> - cpu_physical_memory_set_dirty_flags(ram_addr, dirty_flags);
> + cpu_physical_memory_set_dirty_flag(ram_addr, MIGRATION_DIRTY_FLAG);
> + cpu_physical_memory_set_dirty_flag(ram_addr, VGA_DIRTY_FLAG);
Worth writing as a single call:
cpu_physical_memory_set_dirty_flag(ram_addr,
MIGRATION_DIRTY_FLAG|VGA_DIRTY_FLAG);
or will that just get in the way of refactoring later in the series?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC 00/28] bitmap handling optimization, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 02/28] memory: cpu_physical_memory_set_dirty_flags() result is never used, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 01/28] Move prototypes to memory.h, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 04/28] exec: use accessor function to know if memory is dirty, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 03/28] memory: cpu_physical_memory_set_dirty_range() return void, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 05/28] memory: create function to set a single dirty bit, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 07/28] memory: make cpu_physical_memory_is_dirty return bool, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 06/28] exec: create function to get a single dirty bit, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 08/28] exec: simplify notdirty_mem_write(), Juan Quintela, 2013/10/09
- Re: [Qemu-devel] [PATCH 08/28] exec: simplify notdirty_mem_write(),
Eric Blake <=
- [Qemu-devel] [PATCH 10/28] memory: set single dirty flags when possible, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 09/28] memory: all users of cpu_physical_memory_get_dirty used only one flag, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 11/28] memory: cpu_physical_memory_set_dirty_range() allways dirty all flags, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 13/28] memory: use DIRTY_MEMORY_* instead of *_DIRTY_FLAG, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 12/28] memory: cpu_physical_memory_mask_dirty_range() allways clear a single flag, Juan Quintela, 2013/10/09
- [Qemu-devel] [PATCH 14/28] memory: use bit 2 for migration, Juan Quintela, 2013/10/09