[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/13] Add xxspltw
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 12/13] Add xxspltw |
Date: |
Wed, 09 Oct 2013 13:19:15 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
On 10/04/2013 06:26 AM, Tom Musta wrote:
> + case 0: {
> + tcg_gen_mov_i64(b, cpu_vsrh(xB(ctx->opcode)));
> + tcg_gen_andi_i64(b, b, 0xFFFFFFFF00000000ul);
> + tcg_gen_shri_i64(b, b, 32);
> + break;
...
> + case 2: {
> + tcg_gen_mov_i64(b, cpu_vsrl(xB(ctx->opcode)));
> + tcg_gen_andi_i64(b, b, 0xFFFFFFFF00000000ul);
> + tcg_gen_shri_i64(b, b, 32);
> + break;
No need for the and.
Perhaps better as
TCGv_i64 vsr = (uim & 2 ? cpu_vrsl(xb) : cpu_vrsh(xb));
if (uim & 1) {
tcg_gen_ext32u_i64(b, vsr);
} else {
tcg_gen_shri_i32(b, vsr, 32);
}
> + tcg_gen_shli_i64(b2, b, 32);
> + tcg_gen_or_i64(b, b, b2);
deposit.
r~
- [Qemu-devel] [PATCH 05/13] Add stxsdx, (continued)
- [Qemu-devel] [PATCH 05/13] Add stxsdx, Tom Musta, 2013/10/04
- [Qemu-devel] [PATCH 06/13] Add stxvw4x, Tom Musta, 2013/10/04
- [Qemu-devel] [PATCH 07/13] Add VSX Scalar Move Instructions, Tom Musta, 2013/10/04
- [Qemu-devel] [PATCH 08/13] Add VSX Vector Move Instructions, Tom Musta, 2013/10/04
- [Qemu-devel] [PATCH 09/13] Add Power7 VSX Logical Instructions, Tom Musta, 2013/10/04
- [Qemu-devel] [PATCH 10/13] Add xxmrgh/xxmrgl, Tom Musta, 2013/10/04
- [Qemu-devel] [PATCH 11/13] Add xxsel, Tom Musta, 2013/10/04
- [Qemu-devel] [PATCH 12/13] Add xxspltw, Tom Musta, 2013/10/04
- Re: [Qemu-devel] [PATCH 12/13] Add xxspltw,
Richard Henderson <=
- [Qemu-devel] [PATCH 13/13] Add xxsldwi, Tom Musta, 2013/10/04