[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RFC 3/9] apic: Document why cannot_instantiate_with_
From: |
armbru |
Subject: |
[Qemu-devel] [PATCH RFC 3/9] apic: Document why cannot_instantiate_with_device_add_yet |
Date: |
Thu, 10 Oct 2013 16:42:48 +0200 |
From: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/intc/apic_common.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index ea420c7..aaef054 100644
--- a/hw/intc/apic_common.c
+++ b/hw/intc/apic_common.c
@@ -386,9 +386,13 @@ static void apic_common_class_init(ObjectClass *klass,
void *data)
dc->vmsd = &vmstate_apic_common;
dc->reset = apic_reset_common;
- dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
dc->props = apic_properties_common;
idc->init = apic_init_common;
+ /*
+ * Reason: APIC and CPU need to be wired up by
+ * x86_cpu_apic_create()
+ */
+ dc->cannot_instantiate_with_device_add_yet = true;
}
static const TypeInfo apic_common_type = {
--
1.8.1.4
- [Qemu-devel] [PATCH RFC 0/9] Clean up and fix no_user, armbru, 2013/10/10
- [Qemu-devel] [PATCH RFC 4/9] pci-host: Consistently set cannot_instantiate_with_device_add_yet, armbru, 2013/10/10
- [Qemu-devel] [PATCH RFC 2/9] sysbus: Set cannot_instantiate_with_device_add_yet, armbru, 2013/10/10
- [Qemu-devel] [PATCH RFC 9/9] qdev: Do not let the user try to device_add when it cannot work, armbru, 2013/10/10
- [Qemu-devel] [PATCH RFC 3/9] apic: Document why cannot_instantiate_with_device_add_yet,
armbru <=
- [Qemu-devel] [PATCH RFC 1/9] qdev: Replace no_user by cannot_instantiate_with_device_add_yet, armbru, 2013/10/10
- [Qemu-devel] [PATCH RFC 8/9] isa: Clean up use of cannot_instantiate_with_device_add_yet, armbru, 2013/10/10
- [Qemu-devel] Should the i8259 devices remain no-user? (was: [PATCH RFC 8/9] isa: Clean up use of cannot_instantiate_with_device_add_yet), Markus Armbruster, 2013/10/15
- Re: [Qemu-devel] Should the i8259 devices remain no-user?, Paolo Bonzini, 2013/10/15
- Re: [Qemu-devel] Should the i8259 devices remain no-user?, Markus Armbruster, 2013/10/16
- Re: [Qemu-devel] Should the i8259 devices remain no-user?, Paolo Bonzini, 2013/10/16
- Re: [Qemu-devel] Should the i8259 devices remain no-user?, Markus Armbruster, 2013/10/16
- Re: [Qemu-devel] Should the i8259 devices remain no-user?, BALATON Zoltan, 2013/10/16
- Re: [Qemu-devel] Should the i8259 devices remain no-user?, Paolo Bonzini, 2013/10/16
- Re: [Qemu-devel] fix clearing i8259 IRQ lines (Was: Should the i8259 devices remain no-user?), Matthew Ogilvie, 2013/10/26