Re: [Qemu-devel] [PATCH 0/2] Improve -device command line help some more

[Marcel Apfelbaum]

On Thu, 2013-10-10 at 15:00 +0200, address@hidden wrote:
> From: Markus Armbruster <address@hidden>
> 
> Marcel's recent improvements (commit dbd94f8..125ee0e) go in the right
> direction, but there are issues (see PATCH 1/2), and I find the
> resulting help output still hard to read.
> 
> This series redoes the help printing part of Marcel's series.  Result
> looks like this (moxie picked as example for brevity):
> 
>     $ qemu-system-moxie -device help
>     Controller/Bridge/Hub devices:
>     name "usb-host", bus usb-bus
>     name "usb-hub", bus usb-bus
> 
>     Storage devices:
>     name "scsi-block", bus SCSI, desc "SCSI block device passthrough"
>     name "scsi-cd", bus SCSI, desc "virtual SCSI CD-ROM"
>     name "scsi-disk", bus SCSI, desc "virtual SCSI disk or CD-ROM (legacy)"
>     name "scsi-generic", bus SCSI, desc "pass through generic scsi device 
> (/dev/sg*)"
>     name "scsi-hd", bus SCSI, desc "virtual SCSI disk"
> 
>     Input devices:
>     name "isa-serial", bus ISA
>     name "usb-kbd", bus usb-bus
>     name "usb-mouse", bus usb-bus
>     name "usb-tablet", bus usb-bus
> 
>     Misc devices:
>     name "smbus-eeprom", bus i2c-bus
>     name "usb-redir", bus usb-bus
> 
> Additionally, "info qdm" is again just like "device_add help" with
> no-user devices included.

I think that adding the category in each line may be
useful when using grep, but I suppose that we can grep by category 
with -A x.

Thanks for continuing to improve the help output.
Marcel,

Reviewed-by: Marcel Apfelbaum <address@hidden>

> 
> Markus Armbruster (2):
>   Mostly revert "qemu-help: Sort devices by logical functionality"
>   qdev-monitor: Group "device_add help" and "info qdm" by category
> 
>  include/hw/qdev-core.h | 16 ----------
>  qdev-monitor.c         | 85 
> ++++++++++++++++++++++++++++----------------------
>  2 files changed, 47 insertions(+), 54 deletions(-)
>