[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open |
|
Date: |
Fri, 11 Oct 2013 06:42:31 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
On 10/11/2013 06:30 AM, Max Reitz wrote:
> On one occasion, hdev_open() returned -1 in case of an unknown error
> instead of a proper -errno value. Adjust this to match the behavior of
> raw_open() (in raw-win32), which is to return -EINVAL in this case.
> Also, change the call to error_setg*() to match the one in raw_open() as
> well.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> Follow-up to (as suggested by Eric):
> - block/raw-win32: Employ error parameter
> (3/5 from the "block: Employ error parameter" series)
> ---
> block/raw-win32.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature