[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub messag
From: |
Cole Robinson |
Subject: |
Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message |
Date: |
Fri, 11 Oct 2013 11:49:20 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
On 10/11/2013 02:19 AM, Markus Armbruster wrote:
> Cole Robinson <address@hidden> writes:
>
>> Using multiple calls to error_report here means every line is
>> prefaced with the (potentially long) pci-assign command line
>> arguments. Use a single error_report to preserve the intended
>> formatting.
>
> The orthodox way to do this is to use error_report() for the
> (single-line!) error message, then error_printf() for additional
> information. See commit 2da2e52..312fd5f for an example.
>
Sounds good. This code path is always preceded by an error_report() call, we
can just change this massive message to error_printf().
- Cole