qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] mirror: drop local_err in mirror_compelte


From: Fam Zheng
Subject: [Qemu-devel] [PATCH] mirror: drop local_err in mirror_compelte
Date: Sat, 12 Oct 2013 14:33:12 +0800

There is errp passed in, so no need for local_err and error_propagate.

Signed-off-by: Fam Zheng <address@hidden>
---
 block/mirror.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/block/mirror.c b/block/mirror.c
index 7b95acf..f2e9558 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -505,15 +505,13 @@ static void mirror_iostatus_reset(BlockJob *job)
 static void mirror_complete(BlockJob *job, Error **errp)
 {
     MirrorBlockJob *s = container_of(job, MirrorBlockJob, common);
-    Error *local_err = NULL;
     int ret;
 
-    ret = bdrv_open_backing_file(s->target, NULL, &local_err);
+    ret = bdrv_open_backing_file(s->target, NULL, errp);
     if (ret < 0) {
         char backing_filename[PATH_MAX];
         bdrv_get_full_backing_filename(s->target, backing_filename,
                                        sizeof(backing_filename));
-        error_propagate(errp, local_err);
         return;
     }
     if (!s->synced) {
-- 
1.8.3.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]