Re: [Qemu-devel] [RFC PATCH v2 0/3] Fix UST backend for LTTng 2.x

[Mohamad Gebai]

Sorry for the delay, just submitted the updated documentation.

Thanks,
Mohamad

On 13-10-07 08:36 AM, Alex Bennée wrote:
> address@hidden writes:
>
> > Version 2
> >
> > * Fix tracepoint generation error in first version.
> > * Avoid warnings and errors specific to LTTng ust 2.0.
> > * If using LTTng ust 2.0, we can't avoid getting warnings because of the
> >    --warn-common option given to the linker. This is fixed in more recent
> >    versions of LTTng ust.
> Looking good. Builds for me now although I need to do some reading to
> actually test it out. One omission is docs/tracing.txt gives examples
> for the other tracing backend but just refers to "UST utilities should
> be used to list, enable/disable, and dump traces.". Perhaps a few simple
> examples could be added to the document so people can at least confirm
> everything is working as it should be. Otherwise I'm happy.
>
> Reviewed-by: Alex Bennée <address@hidden>
>
> > Mohamad
> >
> > Mohamad Gebai (3):
> >    Fix configure script for LTTng 2.x
> >    Modified the tracetool framework for LTTng 2.x.
> >    Adapt Makefiles to the new LTTng ust interface.
> >
> >   Makefile                                 |    5 ++
> >   configure                                |    9 ++--
> >   scripts/tracetool/backend/events.py      |   44 ++++++++++++++++
> >   scripts/tracetool/backend/ust.py         |   82 ++++++------------------------
> >   scripts/tracetool/format/ust_events_c.py |   30 +++++++++++
> >   scripts/tracetool/format/ust_events_h.py |   57 +++++++++++++++++++++
> >   trace/Makefile.objs                      |   29 ++++++++++-
> >   7 files changed, 183 insertions(+), 73 deletions(-)
> >   create mode 100644 scripts/tracetool/format/ust_events_c.py
> >   create mode 100644 scripts/tracetool/format/ust_events_h.py