Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

[Igor Mammedov]

On Tue, 15 Oct 2013 06:51:30 -0700
Anthony Liguori <address@hidden> wrote:

> On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin <address@hidden> wrote:
> > On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote:
> >> "Michael S. Tsirkin" <address@hidden> writes:
> >>
> >> > Anthony, I know you wanted to review some of the patches,
> >> > since you didn't respond either all's well or you
> >> > could not find the time.
> >> > I think we are better off merging them for 1.7 and then - worst case,
> >> > if major issues surface - disabling the functionality at the last minute
> >> > than delaying the merge even more.
> >>
> >> There is no way I'll pull this for 1.7.  Changes like this aren't going
> >> to get merged at the last minute.
> >
> > Last minute?  This has been on list for months.
> 
> It doesn't matter how long the patches have been on the list.  We have
> a very short testing cycle for releases.
> 
> This pull request lacks any automated testing.  Something like this
> really should come with at least some qtest validation that we are
> still generating the right ACPI tables but certainly could have
> simpler unit tests too.
> 
> There is no statement about what manual testing you actually did.
> Have you run kvm autotest?  Have you tested a variety of Windows
> guests?
I've manually boot/install tested a bunch of x64 based OSes
rhel6/fc18/ws2008/ws2012/ws2003r2/XP
There were no regressions so far.