[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/12] virtio-ccw: move virtio_ccw_stop_ioeve
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 01/12] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug |
|
Date: |
Tue, 15 Oct 2013 17:05:03 +0200 |
On Tue, 15 Oct 2013 16:52:42 +0200
Paolo Bonzini <address@hidden> wrote:
> Similar to the PCI bug that prompted these patches, virtio-ccw will
> segfault after the reworking of hotplug/hot-unplug. Prepare for
> this by moving virtio_ccw_stop_ioeventfd to before the freeing
> of the proxy device.
>
> A better place for this could be the device_unplugged callback
> for the virtio-ccw bus. However, we do not yet have a callback
> that works: this patch avoids the problem while leaving the tree
> bisectable.
>
> Reported-by: Cornelia Huck <address@hidden>
> Suggested-by: Cornelia Huck <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/s390x/virtio-ccw.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Cornelia Huck <address@hidden>