qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 0/3] hw/arm: Add 'virt' platform


From: Tom Sutcliffe
Subject: Re: [Qemu-devel] [PATCH v7 0/3] hw/arm: Add 'virt' platform
Date: Tue, 15 Oct 2013 16:14:51 +0100

On 15 Oct 2013, at 16:00, Peter Maydell <address@hidden> wrote:

> On 15 October 2013 15:58, Tom Sutcliffe <address@hidden> wrote:
>> Thumbs up from me testing on Arndale. My only issue is that virt and 
>> vexpress-a15 add virtio-mmio devices in the opposite order to each other, 
>> for the same set of -device command line arguments. It would avoid future 
>> headaches if we could have these behave the same. My preference would be for 
>> the virt behaviour, as the -device order matches the order in which the 
>> guest Linux kernel adds them to /dev (for virtio-blk-devices at least).
> 
> Oh yes, I'd forgotten you mentioned that. Did anybody ever
> track down *why* the kernel is reading the device tree
> backwards?

Not me :) I assume it's inserting into a linked list at some point by 
repeatedly replacing the head element (which would reverse the order) but where 
it's doing that, whether it's intentional, and what would break if it were 
changed I couldn't say.

> (PS: I'd appreciate it if you didn't drop the qemu-devel cc.)

My mistake!

Tom


reply via email to

[Prev in Thread] Current Thread [Next in Thread]