[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] RFC: KVM _CREATE_DEVICE considered harmful?
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] RFC: KVM _CREATE_DEVICE considered harmful? |
|
Date: |
Wed, 16 Oct 2013 16:59:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 16/10/2013 16:23, Christian Borntraeger ha scritto:
> That would work, but it would change the ioctl number of KVM_*_DEVICE_ADDR,
> due to the changed size of struct kvm_device_attr. We would then need compat
> handlers in the kernel.
Actually I did that on purpose :) but perhaps you're right that the
complication would be too high.
> If we could encode it in the existing interface the impact would be smaller.
> e.g.
>
> #define ATTR_ATTR_MASK 0xffffffffULL
> #define ATTR_LEN_MASK 0xffffffff00000000ULL
>
>
> switch (attr->attr) {
> --->
> switch (attr->attr & ATTR_ATTR_MASK) {
>
> Then we could keep the device model abstraction.
That makes sense too.
Paolo