[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sd: Avoid access to NULL BlockDriverState
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] sd: Avoid access to NULL BlockDriverState |
|
Date: |
Thu, 17 Oct 2013 10:15:23 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 16, 2013 at 03:24:01PM +0200, Andreas Färber wrote:
> Commit 4f8a066b5fc254eeaabbbde56ba4f5b29cc68fdf (blockdev: Remove IF_*
> check for read-only blockdev_init) added a usage of bdrv_is_read_only()
> to sd_init(), which is called for versatilepb, versatileab and
> xilinx-zynq-a9 machines among others with NULL argument by default,
> causing the new qom-test to fail.
>
> Add a check to prevent this.
>
> Suggested-by: Kevin Wolf <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> hw/sd/sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan