[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open |
Date: |
Thu, 17 Oct 2013 14:55:59 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Oct 11, 2013 at 02:30:16PM +0200, Max Reitz wrote:
> On one occasion, hdev_open() returned -1 in case of an unknown error
> instead of a proper -errno value. Adjust this to match the behavior of
> raw_open() (in raw-win32), which is to return -EINVAL in this case.
> Also, change the call to error_setg*() to match the one in raw_open() as
> well.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> Follow-up to (as suggested by Eric):
> - block/raw-win32: Employ error parameter
> (3/5 from the "block: Employ error parameter" series)
> ---
> block/raw-win32.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan