qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64


From: Tom Musta
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64
Date: Thu, 17 Oct 2013 12:58:08 -0500
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1

> On 10/17/2013 11:31 AM, Stefan Weil wrote:
Am 17.10.2013 11:40, schrieb Alexander Graf:
Missing a SoB line.


Alex

There is already a mix of coding styles in fpu/softfloat.c, and your
patch adds large regions of new code.
Therefore I expect that such contributions should respect the QEMU
coding style.

The situation is different if only single lines in some function are
replaced or added.

Stefan


OK .... I will rework the patch to use QEMU style.  And will add the sob.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]