[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/13] block: do not include monitor.h in block.
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 02/13] block: do not include monitor.h in block.c |
Date: |
Fri, 18 Oct 2013 11:36:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 18/10/2013 03:11, Wenchao Xia ha scritto:
> block_int.h already included it.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> block.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/block.c b/block.c
> index 2c15e5d..e92a556 100644
> --- a/block.c
> +++ b/block.c
> @@ -24,7 +24,6 @@
> #include "config-host.h"
> #include "qemu-common.h"
> #include "trace.h"
> -#include "monitor/monitor.h"
> #include "block/block_int.h"
> #include "block/blockjob.h"
> #include "qemu/module.h"
>
Does this cause problems? block.c uses monitor_protocol_event, so it's
good to include the file directly instead of relying on other header files.
Paolo
- [Qemu-devel] [PATCH 00/13] trivial patches for event, error and monitor, Wenchao Xia, 2013/10/18
- [Qemu-devel] [PATCH 02/13] block: do not include monitor.h in block.c, Wenchao Xia, 2013/10/18
- Re: [Qemu-devel] [PATCH 02/13] block: do not include monitor.h in block.c,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 01/13] block: use type MonitorEvent directly, Wenchao Xia, 2013/10/18
- [Qemu-devel] [PATCH 06/13] error: remove error_printf_unless_qmp(), Wenchao Xia, 2013/10/18
- [Qemu-devel] [PATCH 07/13] error: make error_print_loc() static, Wenchao Xia, 2013/10/18
- [Qemu-devel] [PATCH 05/13] error: define struct Error in only one place, Wenchao Xia, 2013/10/18