[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: disallow to specify multicast MAC address
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] net: disallow to specify multicast MAC address |
|
Date: |
Fri, 18 Oct 2013 18:40:25 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Oct 17, 2013 at 07:06:28PM +0400, Dmitry Krivenok wrote:
> +bool net_macaddr_is_multicast(uint8_t *macaddr)
> +{
> + return (macaddr[0] % 2) ? true : false;
> +}
Please use is_multicast_ether_addr() instead. Thanks Amos for pointing
out this function is duplicated.
I have dropped this patch and will merge the next revision instead.