Re: [Qemu-devel] [PATCH v1 4/4] target-arm: Add CP15 VBAR support

[Peter Crosthwaite]

Hi,

> -----Original Message-----
> From: Peter Maydell [mailto:address@hidden
> Sent: Saturday, October 19, 2013 12:06 AM
> To: Peter Crosthwaite
> Cc: QEMU Developers
> Subject: Re: [PATCH v1 4/4] target-arm: Add CP15 VBAR support
>
> On 17 October 2013 11:38, Peter Maydell <address@hidden> wrote:
> > On 10 July 2013 05:23,  <address@hidden> wrote:
> >> From: Nathan Rossi <address@hidden>
> >>
> >> Added Vector Base Address remapping on ARM v7.
> >
> > Apologies for this dropping off my radar for so long.
> > I've had a bit of a think and I think that you're right that we can
> > put in this register as part of our "random things we provide even
> > though we aren't strictly implementing all of TZ", like the existing
> > SCR register support.
> >
> >> +static int vbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
> >> +                      uint64_t value) {
> >> +    value &= (1 << 31);
> >
> > This seems spurious -- we end up ignoring all but the high bit of the
> > written value.
> >
> >> +    env->cp15.c12_vbar = value & ~0x1Ful;
> >> +    return 0;
> >> +}
> >> +
> >
> > Otherwise looks OK.
>
> Update: I've removed the spurious mask line noted above and added the edited
> patch to target-arm.next.
>

Thanks Peter,

Sorry about the delays my end.

Regards,
Peter

> thanks
> -- PMM



This email and any attachments are intended for the sole use of the named 
recipient(s) and contain(s) confidential information that may be proprietary, 
privileged or copyrighted under applicable law. If you are not the intended 
recipient, do not read, copy, or forward this email message or any attachments. 
Delete this email message and any attachments immediately.