Re: [Qemu-devel] [PATCH v4 1/5] Fix configure script for LTTng 2.x

[Mohamad Gebai]

On 13-10-18 10:05 AM, Stefan Hajnoczi wrote:
> On Fri, Oct 18, 2013 at 02:39:49AM -0400, Mohamad Gebai wrote:
> > Signed-off-by: Mohamad Gebai <address@hidden>
> > ---
> >   configure |    9 ++++-----
> >   1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 23dbaaf..627054c 100755
> > --- a/configure
> > +++ b/configure
> > @@ -3287,15 +3287,14 @@ fi
> >   # For 'ust' backend, test if ust headers are present
> >   if test "$trace_backend" = "ust"; then
> >     cat > $TMPC << EOF
> > -#include <ust/tracepoint.h>
> > -#include <ust/marker.h>
> > +#include <lttng/tracepoint.h>
> >   int main(void) { return 0; }
> >   EOF
> >     if compile_prog "" "" ; then
> > -    LIBS="-lust -lurcu-bp $LIBS"
> > -    libs_qga="-lust -lurcu-bp $libs_qga"
> > +    LIBS="-llttng-ust -lurcu-bp -ldl $LIBS"
> > +    libs_qga="-llttng-ust -lurcu-bp -ldl $libs_qga"
> Please switch to pkg-config instead of hardcoding particular flags.  I
> checked that Fedora and Debian ship the pkg-config file.
Unfortunately, some missing files in the Ubuntu package make it 
impossible to use pkg-config for versions of Ubuntu older than 13.10 
(like Ubuntu 12.04 which is a LTS). Would you be okay with these flags?