[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[]
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[] |
Date: |
Mon, 21 Oct 2013 21:47:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
On 10/21/2013 03:16 AM, Wenchao Xia wrote:
> Use the generated table in qapi-types.h.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> monitor.c | 36 ++----------------------------------
> 1 files changed, 2 insertions(+), 34 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
(but may change if you rebase things to avoid churn in 3/5)
> @@ -1070,7 +1038,7 @@ EventInfoList *qmp_query_events(Error **errp)
> QEvent e;
>
> for (e = 0 ; e < Q_EVENT_MAX ; e++) {
> - const char *event_name = monitor_event_names[e];
> + const char *event_name = QEvent_lookup[e];
> assert(event_name != NULL);
> info = g_malloc0(sizeof(*info));
> info->value = g_malloc0(sizeof(*info->value));
>
Remember this spot in patch 6/6...
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, (continued)
- [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/21
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Eric Blake, 2013/10/21
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/21
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Paolo Bonzini, 2013/10/28
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/29
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Eric Blake, 2013/10/29
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/30
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Kevin Wolf, 2013/10/29
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/30
[Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[], Wenchao Xia, 2013/10/21
- Re: [Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[],
Eric Blake <=
[Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/21
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Eric Blake, 2013/10/21
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/21
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Eric Blake, 2013/10/21
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/23
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Eric Blake, 2013/10/29
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/30
Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/22
Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Eric Blake, 2013/10/22
Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/22