Re: [Qemu-devel] [v2 01/13] Abandon GEN_VSX_* macros

[Paolo Bonzini]

Il 11/10/2013 13:55, Tom Musta ha scritto:
> This patch eliminates the GEN_VSX_LXVNX/GEN_VSX_STXVNX macros which
> did not provide significant value above the general GEN_HANDLER_E
> macro.
> 
> Signed-off-by: Tom Musta <address@hidden>
> ---
>  target-ppc/translate.c |   12 ++----------
>  1 files changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 66fcd80..bd5e89d 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -9518,17 +9518,9 @@ GEN_VAFORM_PAIRED(vmsumshm, vmsumshs, 20),
>  GEN_VAFORM_PAIRED(vsel, vperm, 21),
>  GEN_VAFORM_PAIRED(vmaddfp, vnmsubfp, 23),
> 
> -#undef  GEN_VSX_LXVNX
> -#define GEN_VSX_LXVNX(name, opc2,
> opc3)                                        \
> -  GEN_HANDLER_E(lxv##name, 0x1F, opc2, opc3, 0x00000000, PPC_NONE,
> PPC2_VSX)
> +GEN_HANDLER_E(lxvd2x, 0x1F, 0x0C, 0x1A, 0, PPC_NONE, PPC2_VSX),
> 
> -GEN_VSX_LXVNX(d2x, 0x0C, 0x1A),
> -
> -#undef  GEN_VSX_STXVNX
> -#define GEN_VSX_STXVNX(name, opc2,
> opc3)                                       \
> -  GEN_HANDLER_E(stxv##name, 0x1F, opc2, opc3, 0x00000000, PPC_NONE,
> PPC2_VSX)
> -
> -GEN_VSX_STXVNX(d2x, 0x0C, 0x1E),
> +GEN_HANDLER_E(stxvd2x, 0x1F, 0xC, 0x1E, 0, PPC_NONE, PPC2_VSX),
> 
>  #undef GEN_XX3FORM_DM
>  #define GEN_XX3FORM_DM(name, opc2, opc3) \

Reviewed-by: Paolo Bonzini <address@hidden>