Re: [Qemu-devel] [PATCH 1/2] target-arm: sort TCG cpreg list by 64bit id version

[Peter Maydell]

On 11 October 2013 18:38, Alvise Rigo <address@hidden> wrote:
> Both KVM and TCG populate the cpreg_list with 64 bit registers IDs, but in 
> the TCG side the cpreg_list is sorted using the 32 bit id version while in 
> the kvm side the 64 bit id version is used.
> This patch makes the sorting of the cpreg_list consistent between KVM and TCG.
>
> Signed-off-by: Alvise Rigo <address@hidden>

Thanks, applied this and 2/2 to target-arm.next.
A couple of formatting notes for next time:
 * please use checkpatch.pl to check you haven't got
   coding style violations (both these patches had bad indent
   and missing braces)
 * please wrap your commit messages rather than having them
   be one very long line
 * if you're submitting a patchset with more than one patch
   in it please include a cover letter email (this set doesn't
   seem to have one)

I've fixed these issues up in my queue this time round since
I wanted to get the patches out in a pullreq this week, but
usually I'd just bounce a patch back for that sort of error.

(If you haven't read http://qemu-project.org/Contribute/SubmitAPatch
I'd recommend it; it tries to list various minor formatting
and process issues that can trip up first-time submitters.)

thanks
-- PMM