Re: [Qemu-devel] [PATCH v2] net: disallow to specify multicast MAC address

[Amos Kong]

On Mon, Oct 21, 2013 at 4:08 PM, Dmitry Krivenok
<address@hidden> wrote:
> Changes to v1:
> 1) Resolved names clash in include/net/eth.h
> 2) Reused is_multicast_ether_addr() from that header for MAC check.
>
> Signed-off-by: Dmitry V. Krivenok <address@hidden>

Reviewed-by: Amos Kong <address@hidden>

> ---
>  include/net/eth.h | 6 +++---
>  net/net.c         | 6 ++++++
>  2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/include/net/eth.h b/include/net/eth.h
> index 1d48e06..b3273b8 100644
> --- a/include/net/eth.h
> +++ b/include/net/eth.h
> @@ -84,7 +84,7 @@ typedef struct ip_pseudo_header {
>  } ip_pseudo_header;
>
>  /* IPv6 address */
> -struct in6_addr {
> +struct in6_address {
>      union {
>          uint8_t __u6_addr8[16];
>      } __in6_u;
> @@ -105,8 +105,8 @@ struct ip6_header {
>              uint8_t  ip6_un3_ecn;  /* 2 bits ECN, top 6 bits payload length 
> */
>          } ip6_un3;
>      } ip6_ctlun;
> -    struct in6_addr ip6_src;     /* source address */
> -    struct in6_addr ip6_dst;     /* destination address */
> +    struct in6_address ip6_src;    /* source address */
> +    struct in6_address ip6_dst;    /* destination address */
>  };
>
>  struct ip6_ext_hdr {
...