[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Don't copy backing file name on error
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: Don't copy backing file name on error |
|
Date: |
Mon, 28 Oct 2013 17:37:53 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 26.10.2013 um 15:44 hat Max Reitz geschrieben:
> bdrv_open_backing_file() tries to copy the backing file name using
> pstrcpy directly after calling bdrv_open() to open the backing file
> without checking whether that was actually successful. If it was not,
> ps->backing_hd->file will probably be NULL and qemu will crash.
>
> Fix this by moving pstrcpy after checking whether bdrv_open() succeeded.
>
> Signed-off-by: Max Reitz <address@hidden>
Thanks, applied. A test case wouldn't hurt, though.
Kevin