Re: [Qemu-devel] [PATCH for 1.7] pc: disable pci-info

[Michael S. Tsirkin]

On Tue, Oct 29, 2013 at 03:35:07PM +0100, Igor Mammedov wrote:
> The BIOS that we ship in 1.7 does not use pci info
> from host and so far isn't going to use it.
> Taking in account problems it caused see 9604f70fdf and
> to avoid future incompatibility issues, it's safest to
> disable that interface by default for all machine types
> including 1.7 as it was never exposed/used by guest.
> And properly remove/cleanup it during 1.8 development cycle.
> 
> Signed-off-by: Igor Mammedov <address@hidden>

Reviewed-by: Michael S. Tsirkin <address@hidden>

> ---
>  hw/i386/pc_piix.c |    3 ++-
>  hw/i386/pc_q35.c  |    3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index c6042c7..4a4d969 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -58,7 +58,8 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 
> };
>  static const int ide_irq[MAX_IDE_BUS] = { 14, 15 };
>  
>  static bool has_pvpanic;
> -static bool has_pci_info = true;
> +/* TODO: remove unused "etc/pci-info" */
> +static bool has_pci_info;
>  
>  /* PC hardware initialisation */
>  static void pc_init1(QEMUMachineInitArgs *args,
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index ca84e1c..8e5c1ae 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -48,7 +48,8 @@
>  #define MAX_SATA_PORTS     6
>  
>  static bool has_pvpanic;
> -static bool has_pci_info = true;
> +/* TODO: remove unused "etc/pci-info" */
> +static bool has_pci_info;
>  
>  /* PC hardware initialisation */
>  static void pc_q35_init(QEMUMachineInitArgs *args)
> -- 
> 1.7.1