Re: [Qemu-devel] [PATCH V2 00/19] PowerPC VSX Stage 3

[Richard Henderson]

On 10/29/2013 06:01 AM, Tom Musta wrote:
> V2: Implemented changes based on feedback from Richard Henderson and
> Peter Maydell:
>     - Included float64_to_uint64() patch in this series rather than just
>       cite it as a pre-requesite.
>     - Isolated float32_to_uint64() in its own patch.
>     - Re-implemented helpers and eliminated the need for some of the proposed
>       softfloat routines (float*_is_denormal, float*_get_unbiased_exp).
>     - Re-implemented severy helpers so that corner cases (e.g. invalid
>       operations) are detected by softfloat.
>     - Re-implemented fused multiply-add to use the softfloat muladd routines.
>     - Re-implemented the min/max instructions to used the softfloat
>       min/max functions.
>     - assorted style fixes
> 
> Tom Musta (19):
>   Fix float64_to_uint64
>   Add float32_to_uint64()
>   Add set_fprf Argument to fload_invalid_op_excp()
>   General Support for VSX Helpers
>   Add VSX ISA2.06 xadd/xsub Instructions
>   Add VSX ISA2.06 xmul Instructions
>   Add VSX ISA2.06 xdiv Instructions
>   Add VSX ISA2.06 xre Instructions
>   Add VSX ISA2.06 xsqrt Instructions
>   Add VSX ISA2.06 xrsqrte Instructions
>   Add VSX ISA2.06 xtdiv Instructions
>   Add VSX ISA2.06 xtsqrt Instructions
>   Add VSX ISA2.06 Multiply Add Instructions
>   Add VSX xscmp*dp Instructions
>   Add VSX xmax/xmin Instructions
>   Add VSX Vector Compare Instructions
>   Add VSX Floating Point to Floating Point Conversion Instructions
>   Add VSX ISA2.06 Integer Conversion Instructions
>   Add VSX Rounding Instructions

Reviewed-by: Richard Henderson <address@hidden>

Looks good.


r~