[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks |
Date: |
Wed, 30 Oct 2013 09:28:46 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Oct 18, 2013 at 09:10:43PM +0200, Peter Lieven wrote:
>
>
> > Am 18.10.2013 um 15:50 schrieb Paolo Bonzini <address@hidden>:
> >
> > Il 18/10/2013 15:26, Peter Lieven ha scritto:
> >>>
> >>>
> >>> - bdrv_discard_zeroes for bdrv_has_discard_write_zeroes
> >> This would conform to the linux ioctl BLKDISCARDZEROES.
> >> However, we need the write_zeroes operation for a guarantee
> >> that zeroes are return.
> >
> > Yes. I'm fine with the current names actually, just thinking loudly.
> >
> >>> - bdrv_unallocated_blocks_are_zero for bdrv_has_discard_zeroes
> >>>
> >>> But I'm not sure why we have different BlockDriver APIs. I'd rather put
> >>> the new flags in BlockDriverInfo, and make the new functions simple
> >>> wrappers around bdrv_get_info. I think I proposed that before, maybe I
> >>> wasn't clear or I was misunderstood.
> >> I think Kevin wanted to have special functions for this.
> >
> > Yes, but I think he referred to block.c functions not BlockDriver functions.
>
> Ok, if Stefan and Kevin agree i will change it once more. I Would also like
> some Feedback on the new names for the functions and changed description. I
> can send a respin next week then.
(Catching up with old mails)
Fine here.
Stefan
- [Qemu-devel] [PATCHv4 10/17] iscsi: set limits in BlockDriverState, (continued)
- [Qemu-devel] [PATCHv4 10/17] iscsi: set limits in BlockDriverState, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/08
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/18
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Paolo Bonzini, 2013/10/18
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/18
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/30
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/18
[Qemu-devel] [PATCHv4 12/17] iscsi: add bdrv_co_write_zeroes, Peter Lieven, 2013/10/08
[Qemu-devel] [PATCHv4 13/17] block: introduce bdrv_make_zero, Peter Lieven, 2013/10/08
[Qemu-devel] [PATCHv4 16/17] qemu-img: conditionally zero out target on convert, Peter Lieven, 2013/10/08
[Qemu-devel] [PATCHv4 15/17] qemu-img: add support for fully allocated images, Peter Lieven, 2013/10/08
[Qemu-devel] [PATCHv4 17/17] block/raw: copy BlockLimits on raw_open, Peter Lieven, 2013/10/08