Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

[Paolo Bonzini]

Il 29/10/2013 19:30, Kevin Wolf ha scritto:
> Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben:
>> Hi all,
>>
>> this is some cleanup to the IDE code that I started long ago
>> and picked up again on my flight back from KVM Forum...
>>
>> The patches clean up the callbacks to prepare for implementing request
>> retry for AHCI.  After these patches, PIO retry should work for AHCI and
>> non-NCQ retry should be very close (you need an implementation of the
>> new restart_dma callback).  NCQ retry and save/restore is AHCI-specific
>> and has to be done separately, similar to how we do it for SCSI already.
>>
>> Patches 1-4 set up a new (incomplete) testcase.  Patches 5-13 are no-op
>> cleanups, or so I hope.  Patches 14-23 genericize retry and make it
>> "just work" for all adapters for PIO.  Patch 24 is another cleanup that
>> could probably be moved earlier in the series.
>>
>> Throwing it out since I know Kevin and mst are working on AHCI, to avoid
>> doing duplicate work.  Patches 2 and 4 are known to be racy and
>> incomplete.  Extremely light testing, if something breaks tells me and
>> I'll look at it.
> 
> You forgot some CCs it seems. You're lucky that I'm reading qemu-devel
> today, for the first time in two weeks or so. CCing myself so I can
> hopefully have a look tomorrow.

While you finish reviewing, I pushed a version that actually boots
guests on my github repo's ide-cb branch.  I have added a patch to
enable restart for the ISA IDE controller; it cannot be tested the same
way as the PCI one (no ioapic on -M isapc), but it is less hacky than
what I had done for AHCI.

Paolo